-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Add pure alpine flavor #1465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
absolute love! <3
fails due to kernel and initramfs being in different versions, new package with both bundled incoming. |
weird, it passes locally with no issues the autoinstall test, in fact is fast af (67 seconds) |
66b3d0e
to
a4f4a10
Compare
@mudler this now passes all basic tests except the upgrade-to-latest which makes sense because it moves from an opensuse to a pure alpine system, so until release+1 that test wont work. Anything that you want me to test on this? Any scenarios? I manually installed k3s on it, but was going to test a provider with this and encryption next |
I havent tested this on rpi AT ALL. So no idea if this would work. |
Thanks @mauromorales ! I think I screwed up because dracut should not be there 😭 |
Time to get this ball running again.... |
f0bee7c
to
80cd3df
Compare
only thing missing for x86 is a missing cryptsetup in the initramfs, then it should pass the encryption tests as well. For rpi, needs manual testing. |
Signed-off-by: Itxaka <itxaka@kairos.io>
cb377e2
to
82973e9
Compare
This now should pass all tests, both other flavors and alpine pure, including encryption. Only thing missing:
|
rpi boots as expected. Minor issue with machine-id, seems to be generated during initramfs but not in the correct size somehow? So on rootfs switch dbus complains about it and cant start...
|
This is what is autogenerated during initramfs I guess:
And this is the proper format:
|
Needed to clean up /var/lib/dbus/machine-id as seems like its created during base image build! Also, expansion of COS_PERSISTENT does not work, maybe missing a udev trigger somewhere? udev is run on the initramfs start and luks tests confirmt hat the /dev/disk/by-label is filled correctly, otherwise it cant work as expected... so no idea why that is happening, iut doesnt seem to find the partition correctly somehow. |
kairos-agent running twice on datasource -> Fixed by kairos-io/packages#489 I think this is mostly covered, only thing missing is:
|
Maybe relevant? Line 351 in 750b0d1
|
not reall, that would be good, but something is creating a /var/lib/dbus/machine-id which is not correct...no idea what, maybe udev, maybe busybox with its services... Anyway, its fixed now :) |
includes bpf for alpine fix in config files includes changes for the network and sysext generic packages includes missing deps for initramfs in flavors includes fixes for config files includes fixes for tty overwriting on alpine includes fixes for cgroups on alpine Signed-off-by: Itxaka <itxaka@kairos.io>
Signed-off-by: Itxaka <itxaka@kairos.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work @Itxaka 👏 👏
only thing missing is provider-kairos with p2p enabled takes over the terminals witht he output, blocking the loging console. Something minor IMHO. |
Signed-off-by: Itxaka <itxaka@kairos.io>
Missing things:
|
Signed-off-by: Itxaka <itxaka@kairos.io>
Signed-off-by: Itxaka <itxaka@kairos.io>
What this PR does / why we need it:
Provides a pure alpine flavor with alpine kernel and custom initrd
Requires:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #