Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Sync all kairos entries in livecd #1493

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Conversation

Itxaka
Copy link
Member

@Itxaka Itxaka commented Jun 8, 2023

Some had vga some didnt

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Some had vga some didnt

Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
@Itxaka Itxaka added the papercut You wont die from this, but its very annoying label Jun 8, 2023
@Itxaka Itxaka requested a review from a team June 8, 2023 13:30
Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though the vga stuff is always complaining that is deprecated LOL

@Itxaka
Copy link
Member Author

Itxaka commented Jun 8, 2023

lgtm, though the vga stuff is always complaining that is deprecated LOL

on opensuse I think, fedora seems to maintain it. But indeed we should move to the other stanza for everything I guess

@jimmykarily
Copy link
Contributor

Since the test is broken on master too, we moved this to another issue: #1526

@Itxaka Itxaka merged commit 5451d0c into kairos-io:master Jun 19, 2023
37 of 39 checks passed
@Itxaka Itxaka deleted the vga_795 branch June 19, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
papercut You wont die from this, but its very annoying
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants