🐛 Do not remount /tmp under alpine #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Immucore is already mounting /tmp on boot so we should not re-mount it, or at least if we do, we should check first if its mounted to not shadow existing /tmp files Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
jimmykarily
approved these changes
Jun 20, 2023
Itxaka
added a commit
to Itxaka/kairos
that referenced
this pull request
Jun 21, 2023
Immucore is already mounting /tmp on boot so we should not re-mount it, or at least if we do, we should check first if its mounted to not shadow existing /tmp files Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com> (cherry picked from commit bb25e05)
mauromorales
pushed a commit
that referenced
this pull request
Jun 21, 2023
Immucore is already mounting /tmp on boot so we should not re-mount it, or at least if we do, we should check first if its mounted to not shadow existing /tmp files Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
mauromorales
pushed a commit
that referenced
this pull request
Jun 21, 2023
Immucore is already mounting /tmp on boot so we should not re-mount it, or at least if we do, we should check first if its mounted to not shadow existing /tmp files Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com> Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
mauromorales
pushed a commit
that referenced
this pull request
Jun 30, 2023
Immucore is already mounting /tmp on boot so we should not re-mount it, or at least if we do, we should check first if its mounted to not shadow existing /tmp files Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Immucore is already mounting /tmp on boot so we should not re-mount it, or at least if we do, we should check first if its mounted to not shadow existing /tmp files
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1526