Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build ubuntu fips framework image #1544

Merged
merged 4 commits into from
Jun 22, 2023
Merged

Conversation

jimmykarily
Copy link
Contributor

to allow users to build fips enabled ubuntu flavors from scratch

https://kairos.io/docs/reference/build-from-scratch/

Fixes #1539

to allow users to build fips enabled ubuntu flavors from scratch

https://kairos.io/docs/reference/build-from-scratch/

Signed-off-by: Dimitris Karakasilis <dimitris@spectrocloud.com>
framework-profile.yaml Outdated Show resolved Hide resolved
framework-profile.yaml Outdated Show resolved Hide resolved
@jimmykarily jimmykarily force-pushed the add-fips-framework-image branch 7 times, most recently from cba0b30 to a28a3d8 Compare June 22, 2023 14:31
since we don't need isos for them. Isos need to be built manually (from
scratch) because to have a fips enabled flavor you need to have a fips
enabled OS in general.

Signed-off-by: Ettore Di Giacinto <ettore@spectrocloud.com>
This was a PR suggestion

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
@jimmykarily jimmykarily enabled auto-merge (squash) June 22, 2023 15:11
mauromorales
mauromorales previously approved these changes Jun 22, 2023
Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Itxaka
Itxaka previously approved these changes Jun 22, 2023
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
@jimmykarily jimmykarily dismissed stale reviews from Itxaka and mauromorales via 8e65bf5 June 22, 2023 19:44
@jimmykarily
Copy link
Contributor Author

I sent a commit to fix the broken test. Won't wait for CI to save some time and get the framework image build (only happens on master). If it breaks, I'll fix it on master.

@jimmykarily jimmykarily merged commit f883e8e into master Jun 22, 2023
10 of 30 checks passed
@jimmykarily jimmykarily deleted the add-fips-framework-image branch June 22, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

build framework-fips image
4 participants