Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤖 Test PRs only on one flavor #1559

Closed
wants to merge 19 commits into from
Closed

🤖 Test PRs only on one flavor #1559

wants to merge 19 commits into from

Conversation

jimmykarily
Copy link
Contributor

@jimmykarily jimmykarily commented Jun 27, 2023 •
edited
Loading

Refactor all jobs to reusable workflows so that we can construct a PR and a master pipeline my mixing and matching jobs as desired.

Fixes #1556

@jimmykarily jimmykarily self-assigned this Jun 27, 2023
mudler
mudler previously approved these changes Jun 27, 2023
View reviewed changes
@mudler mudler changed the title Move build job to a reusable workflow 🤖 Move build job to a reusable workflow Jun 27, 2023
@jimmykarily
Copy link
Contributor Author

An alternative would be to run the whole workflow (build + test) for only one flavor on PRs and if that passes, we run some more. I'm only concerned that we have some code switched to identify openrc based flavors and we do things differently then (check isFlavor method in tests).

Otoh, maybe that's not creating issues as often as to justify delaying all PRs.

@jimmykarily jimmykarily changed the title 🤖 Move build job to a reusable workflow 🤖 Test PRs only on one flavor Jun 27, 2023
jimmykarily
jimmykarily commented Jun 27, 2023
View reviewed changes
.github/workflows/image-arm-pr.yaml

jobs:
docker:
uses: kairos-io/kairos/.github/workflows/reusable-docker-arm-build.yaml@1556-pr-one-flavor
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change these to master right before merging. Right now if I do, it won't find the definition of that workflow.

@jimmykarily jimmykarily marked this pull request as ready for review June 27, 2023 14:03
@jimmykarily
Copy link
Contributor Author

I'll remove the mandatory checks for merging that are not going to run anymore

@jimmykarily
Copy link
Contributor Author

Switching the zfs test to run on opensuse-leap broke it because zpool is not installed:

kairos/tests/zfs_test.go

Line 41 in 0294acd

out, err = vm.Sudo("zpool create pool0 -m /usr/local/pool0 /usr/local/disk0.img /usr/local/disk1.img")

Obviously on ubuntu (where this test used to run), it's installed.

@jimmykarily
Copy link
Contributor Author

Strange, I tried this: 8b5d877#diff-52ac78a83f922b3f0116bb67b1aa8100a7620a3be6d63b00ef53cb1495e4eb19R71 on a docker container and it seems to provide zpool.

@jimmykarily
Copy link
Contributor Author

It was removed immediately after: c22b38a#diff-01f2970c67918dfa463783e91789e617d04d30b4555f9b2e1c156e91435eb33fL84

@jimmykarily
Copy link
Contributor Author

I'll try switching to ubuntu for PRs

@mauromorales mauromorales self-assigned this Jul 5, 2023
@jimmykarily @mauromorales
Move build job to a reusable workflow
bad051c 
If this works, we will move all jobs to reusable workflows so that we
can construct a PR and a master pipeline my mixing and matching jobs as
desired.

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@jimmykarily @mauromorales
Move build-framework to reusable workflow too
ef7a14a 
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@jimmykarily @mauromorales
Increase test images livespan to 24h (rebase fix)
422d44b 
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@jimmykarily @mauromorales
Use correct matrix for framework images
9c7d43f 
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@jimmykarily @mauromorales
Rename files (to groups them together) and move install test to reusable
aea5ae5 
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@jimmykarily @mauromorales
Move zfs test to reusable
64b8ee9 
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@jimmykarily @mauromorales
Move qemu acceptance test to reusable
19c6504 
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@jimmykarily @mauromorales
Move qemu bundles test to reusable
2a74597 
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@jimmykarily @mauromorales
Move more jobs to reusable
7156fea 
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@jimmykarily @mauromorales
Move upgrade-with-cli to reusable
a0fe701 
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@jimmykarily @mauromorales
Move upgrade latest with cli to reusable workflow
f2cd28b 
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@jimmykarily @mauromorales
Move encryption tests to reusable
76fcae2 
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@jimmykarily @mauromorales
Split PR with master workflow
55723ca 
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@jimmykarily @mauromorales
Remove the framework job from PRs (which wasn't running anyway)
b5cf5bc 
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@jimmykarily @mauromorales
Use a variable to store the flavor the PRs will test
eb7f8a0 
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@jimmykarily @mauromorales
Split arm workflow to "master" and "PR" and rename files for better g…
446569c 
…rouping

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@jimmykarily @mauromorales
Revert "Use a variable to store the flavor the PRs will test"
6ec7d04 
This reverts commit a0ba1e0.

because it doesn't work

Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@jimmykarily @mauromorales
Use ubuntu to test PRs because opensuse-leap doesn't have zfs support
c2b6749 
It was removed here:

c22b38a#diff-01f2970c67918dfa463783e91789e617d04d30b4555f9b2e1c156e91435eb33fL84

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@jimmykarily @mauromorales
Download the iso in upgrade latest with cli test
c5b571e 
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@mauromorales
Copy link
Member

Reusable workflows merged in #1585

@mauromorales mauromorales mentioned this pull request Jul 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mudler mudler mudler approved these changes

Assignees

@mauromorales mauromorales

Labels
None yet
Projects
🧙Issue tracking board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build only one flavor on PRs
3 participants
@jimmykarily @mauromorales @mudler