✨ Refactor Dockerfiles for Ubuntu based flavors #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
mauromorales
commented
Jul 27, 2023
mauromorales
added
the
refactoring
mauromorales
commented
Jul 27, 2023
mauromorales
commented
Jul 28, 2023
| @@ -80,6 +75,61 @@ RUN apt-get update \ | |||
| zstd \ | |||
| && apt-get remove -y unattended-upgrades && apt-get clean && rm -rf /var/lib/apt/lists/* | |||
|
|
|||
| # Packages and scripts only for specific images | |||
There was a problem hiding this comment.
my guess is that most of the files that are not consistent accross the Dockerfiles on master, are not because they are specifically required but because we failed to keep them in sync. But even with those differences, you can see how this section is actually pretty small and makes it easy to eval the differences between distro versions.
Merged
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
|
Merging since it was agreed during daily. Will open a new PR to address other distros |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking into adding the different packages requested in #1620 and noticed that we again have differences in our Dockerfiles, so I decided to do a POC to evaluate a better way to maintain them, and here's my proposal, which is what I already mentioned in #1400
The major change is to go from individual Dockerfiles per flavor within the same distro, to having a single one for the distro using stage-builds. The reason why I think this makes sense is that most of the content of these files is supposed to be shared across flavors based on a single distribution, and only specific packages or scripts need to run for each different flavor within that distro.