Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Use proper job for the matrix get in framework #1679

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

Itxaka
Copy link
Member

@Itxaka Itxaka commented Aug 3, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Signed-off-by: Itxaka <itxaka@kairos.io>
@Itxaka Itxaka requested a review from a team August 3, 2023 12:43
Signed-off-by: Itxaka <itxaka@kairos.io>
Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Itxaka Itxaka merged commit 00efe75 into kairos-io:master Aug 3, 2023
22 of 23 checks passed
@Itxaka Itxaka deleted the fix_framework_matrix_maybe branch August 3, 2023 17:46
@@ -297,6 +298,9 @@ jobs:
- standard-upgrade-latest
- test-uki
steps:
- uses: actions/checkout@v3
- run: |
git fetch --prune --unshallow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On another branch, we are fixing it like this:

- uses: actions/checkout@v3
with:
fetch-depth: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants