🎨 Bundle bootargs with framework images #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently bootargs is not provided with the framework images so its missing a very important piece to boot which results into BYOI being broken. This patch adds the bootargs.cfg to the framework image. Also the config.txt to the rpi images. Also drops the kernel/initramfs vars from the bootargs as they are set to the default now in the package. Also moves the luet clean under the package list generation as it requires the database of luet to list the packages. Signed-off-by: Itxaka <itxaka@kairos.io>
jimmykarily
previously approved these changes
Sep 7, 2023
|
missing package update with the default kernel/initrd variable set... |
Signed-off-by: Itxaka <itxaka@kairos.io>
Its not needed, we boot from latest release and upgrade to pushed container, the iso is not touched Signed-off-by: Itxaka <itxaka@kairos.io>
Needed for upgrade as we dont upgrade COS_GRUB partition with anything new during upgrade so we are stuck with existing config in there during upgrades Signed-off-by: Itxaka <itxaka@kairos.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently bootargs is not provided with the framework images so its missing a very important piece to boot which results into BYOI being broken.
This patch adds the bootargs.cfg to the framework image. Also the config.txt to the rpi images.
Also drops the kernel/initramfs vars from the bootargs as they are set to the default now in the package.
Also moves the luet clean under the package list generation as it requires the database of luet to list the packages.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1770
Requires: kairos-io/packages#408