🎨 Use a single framework image #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With changes to the packages we now generate the proper service files on the fly so we dont need to have those package separated. We now have 2 framework images, a generic one used for ALL flavors and a fips one, only provided for external consumers as we dont publish any fips enabled artifacts. We also bring both the systemd and openrc package together as they dont affect each other anymore so we can have a single framework. This patch also removes the service enablement as its not needed anymore, it done via config files Reworks the framework jobs to just build and publish the 2 different framework image (generic and fips) Signed-off-by: Itxaka <itxaka@kairos.io>
jimmykarily
approved these changes
Oct 20, 2023
|
Do we need to update the docs here https://kairos.io/docs/reference/build-from-scratch/ ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With changes to the packages we now generate the proper service files on the fly so we dont need to have those package separated.
We now have 2 framework images, a generic one used for ALL flavors and a fips one, only provided for external consumers as we dont publish any fips enabled artifacts.
We also bring both the systemd and openrc package together as they dont affect each other anymore so we can have a single framework.
This patch also removes the service enablement as its not needed anymore, it done via config files
Reworks the framework jobs to just build and publish the 2 different framework image (generic and fips)
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1896