Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce RHEL family #1953

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Introduce RHEL family #1953

merged 3 commits into from
Oct 26, 2023

Conversation

mauromorales
Copy link
Member

  • merges the files for rockylinux and almalinux into a rhel dockerfile
  • decided not to add fedora into this since, it requires to add the epel packages, which might make fedora too close to rhel for our community users. But wonder what you think, is it a good/bad idea to try to also merge that one?

Clean up fedora dockerfile

  • remove packages which are already installed by default "coreutils" and "curl"
  • make it similar to the other dockerfiles for easier maintenance

- merges the files for rockylinux and almalinux into a rhel dockerfile
- decided not to add fedora into this since, it requires to add the epel packages, which might make fedora too close to rhel for our community users. But wonder what you think, is it a good/bad idea to try to also merge that one?

Clean up fedora dockerfile

- remove packages which are already installed by default "coreutils" and "curl"
- make it similar to the other dockerfiles for easier maintenance

Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@mauromorales mauromorales self-assigned this Oct 25, 2023
@mauromorales mauromorales requested a review from a team October 25, 2023 09:25
Earthfile Outdated Show resolved Hide resolved
@Itxaka
Copy link
Member

Itxaka commented Oct 25, 2023

decided not to add fedora into this since, it requires to add the epel packages, which might make fedora too close to rhel for our community users. But wonder what you think, is it a good/bad idea to try to also merge that one?

IMHO I would merge all of them. What packages come from the epel repos? Only the needed ones like zfs? I think merging them all under the same family would be ok as in the end they will have the minimal packages required for a base Kairos flavor, but they can expand it with whatever afterwards, so they can also drop the epel repos on their custom dockerfiles no?

@mauromorales
Copy link
Member Author

@Itxaka ok, will give it a shot and maybe from then we can see how much they differ.

@mauromorales mauromorales marked this pull request as draft October 25, 2023 10:24
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@mauromorales mauromorales marked this pull request as ready for review October 25, 2023 20:13
@mauromorales mauromorales requested a review from a team October 25, 2023 20:13
@mauromorales
Copy link
Member Author

I tried doing a pure rhel but it's a lot more work :( lots of packages are not available, not sure if they are named differently or if I need to enable some repo

images/Dockerfile.rhel Outdated Show resolved Hide resolved
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@mauromorales mauromorales merged commit bd83ec9 into master Oct 26, 2023
6 of 9 checks passed
@mauromorales mauromorales deleted the rhel-family branch October 26, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants