Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge opnesuse families into one #1957

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Merge opnesuse families into one #1957

merged 2 commits into from
Oct 27, 2023

Conversation

mauromorales
Copy link
Member

No description provided.

Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@mauromorales mauromorales marked this pull request as ready for review October 26, 2023 14:00
@mauromorales mauromorales requested a review from a team October 26, 2023 14:00
@mauromorales mauromorales self-assigned this Oct 26, 2023
Copy link
Member

@Itxaka Itxaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we even need the family anymore?

Let me expand on this. It seems that with this patch, the family and the flavor are the same in all but the nvidia board, and Im not even sure that needs a specific family when it has the model stuff no? And in fact it should be of the same family as the ubuntu, just it will have a different path I guess...

@mauromorales
Copy link
Member Author

@Itxaka IMO we still need the family, first because it lets us merge distros like fedora, alma and rocky into a rhel family. Second because it allows the community to try Kairosifying other distros we don't really support, for example if you use Linux Mint or elementary as your base image, you can use the Ubuntu family, if you have PostmarketOS as your base image you can use the alpine family.

@mauromorales
Copy link
Member Author

for the nvidia one, indeed it could be part of Ubuntu, we just felt that this is so unique and probably will not change often, so it was more at risk of braking if merged with the Ubuntu dockerfile. Specially because for the orin it only works with one version of ubuntu even.

@Itxaka
Copy link
Member

Itxaka commented Oct 27, 2023

@Itxaka IMO we still need the family, first because it lets us merge distros like fedora, alma and rocky into a rhel family. Second because it allows the community to try Kairosifying other distros we don't really support, for example if you use Linux Mint or elementary as your base image, you can use the Ubuntu family, if you have PostmarketOS as your base image you can use the alpine family.

Thanks for the explanation!

@mauromorales mauromorales merged commit 73d8dd4 into master Oct 27, 2023
31 of 34 checks passed
@mauromorales mauromorales deleted the opensuse-family branch October 27, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants