Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build RPI3 artifacts #1966

Merged
merged 14 commits into from Jan 3, 2024
Merged

build RPI3 artifacts #1966

merged 14 commits into from Jan 3, 2024

Conversation

Ludea
Copy link
Contributor

@Ludea Ludea commented Oct 27, 2023

What this PR does / why we need it:
Build Rpi3 artifacts

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1816

@jimmykarily jimmykarily requested a review from a team January 3, 2024 10:06
@jimmykarily jimmykarily changed the title buid RPI3 artifacts build RPI3 artifacts Jan 3, 2024
@mauromorales
Copy link
Member

@jimmykarily @mudler I'm not sure how to decide on this one. On the one hand I think it's a good idea to have as many artifacts as possible so users can easily test Kairos, on the other hand this expands the time our CI will be running and besides wait time, we also see issues on release API hits. Also if we plan to have so many ARM builds, it might be a good idea to also consider ARM workers.

IMO the ideal scenario would be to know which artifacts are most interesting for users to consume and just build those, but we don't have any numbers so I guess we need to base the decision differently. Also soon there will also be rpi5 so we will end up with 3 times the artifacts for arm that we originally had, but we don't really know which of the boards is actually mostly used at any point in time.

This might be related to #1527

.github/flavors.json Outdated Show resolved Hide resolved
.github/flavors.json Outdated Show resolved Hide resolved
.github/flavors.json Outdated Show resolved Hide resolved
.github/flavors.json Outdated Show resolved Hide resolved
@mudler
Copy link
Member

mudler commented Jan 3, 2024

@jimmykarily @mudler I'm not sure how to decide on this one. On the one hand I think it's a good idea to have as many artifacts as possible so users can easily test Kairos, on the other hand this expands the time our CI will be running and besides wait time, we also see issues on release API hits. Also if we plan to have so many ARM builds, it might be a good idea to also consider ARM workers.

IMO the ideal scenario would be to know which artifacts are most interesting for users to consume and just build those, but we don't have any numbers so I guess we need to base the decision differently. Also soon there will also be rpi5 so we will end up with 3 times the artifacts for arm that we originally had, but we don't really know which of the boards is actually mostly used at any point in time.

This might be related to #1527

let's at least restrict the number of flavors we are going to support for RPI3 to the ones that are actually manually tested. Let's identify 1, or 2 of them that we can support for now. I'd tempted to say let's go alpine/openSUSE as alpine is small and openSUSE is well tested in our CIs (for amd64, but still). The other solution would be to use self-hosted runners and expand our CI's workers, but we might need to adapt the pipelines to make it work on self-hosted.

@Ludea would be fine with you?

Signed-off-by: Ludea <ludovicw35@hotmail.com>
@Ludea
Copy link
Contributor Author

Ludea commented Jan 3, 2024

Perfect for me, I would like to use alpine

Signed-off-by: Ludea <ludovicw35@hotmail.com>
Signed-off-by: Ludea <ludovicw35@hotmail.com>
Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic, thanks @Ludea for the contribution and @mudler for chipping in.

.github/flavors.json Outdated Show resolved Hide resolved
.github/flavors.json Outdated Show resolved Hide resolved
.github/flavors.json Outdated Show resolved Hide resolved
.github/flavors.json Outdated Show resolved Hide resolved
mauromorales and others added 5 commits January 3, 2024 12:51
Signed-off-by: Mauro Morales <contact@mauromorales.com>
Signed-off-by: Mauro Morales <contact@mauromorales.com>
Signed-off-by: Mauro Morales <contact@mauromorales.com>
Signed-off-by: Mauro Morales <contact@mauromorales.com>
@mauromorales mauromorales enabled auto-merge (squash) January 3, 2024 11:52
@mauromorales mauromorales merged commit e2611d9 into kairos-io:master Jan 3, 2024
2 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Rpi3 artifacts
3 participants