Catch agent issue 174 #2017
Merged
Catch agent issue 174 #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should fail now because of this fix needed: kairos-io/kairos-agent#174 After bumping to the fixed kairos-agent version, the test should be green again. Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: GitHub <noreply@github.com>
Grub configuration for livecd (iso) is installed here: https://github.com/kairos-io/osbuilder/blob/89b014b2b2a1f27bd0c0c5269cecec2a1b8f37bf/tools-image/Dockerfile#L25 and it repositories were bumped in osbuilder to use the latest and updates grub configuration where `console=tty1` is set **after** `console=ttyS0` thus making it the default console for systemd services. Also: - remove not used bootargs.cfg file (has been moved to the "packages" repo) - Change to the DATASOURCE check which is what we need in reality (not CLOUD_INIT which was indirectly checking that DATASOURCE would be set by Earthly) Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
|
Nice, it now fails like it should: https://github.com/kairos-io/kairos/actions/runs/6958662986/job/18934817729?pr=2017 I will now merge this: kairos-io/kairos-agent#174 and bump it here to see if that's fixed |
which has this fix: kairos-io/kairos-agent#174 Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
which, in case of errors, will fail with a timeout but kairos service doesn't allow us to know when the installer is done. That's because the service has `RemainAfterExit=yes` and even if that was removed, the kairos process waits for user input to finish: ``` Installation completed, press enter to go back to the shell. [Yes/no/all/cancel] ``` so there is not sure way to tell whether the kairos installer failed with or without errors. Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is making sure this fix will be tested from now on:
kairos-io/kairos-agent#174