✨ Add labels to kairos container images #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauromorales
changed the title
mauromorales
force-pushed
the
add-labels-to-kairos-images
branch
from
b8162f4
to
26a703f
Compare
jimmykarily
reviewed
Dec 7, 2023
jimmykarily
approved these changes
Dec 7, 2023
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
mauromorales
force-pushed
the
add-labels-to-kairos-images
branch
from
5281f6f
to
bcccbe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only way to distinguish our images right now is via the tag, however, this can be problematic for many reasons e.g. they don't allow all valid characters in semver versions. Also it's very common that one names the image something simple to work locally and then you might forget certain attributes. By adding the labels we would address these issues