Comment while we decide what to do #2085
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
mauromorales
force-pushed
the
broken-test-upgrade
branch
from
b126b03
to
a1f9f16
Compare
|
It's already been tested here: https://github.com/kairos-io/kairos-sdk/blob/74a57eb67370af042872fb67bcd07aa0ee5d02eb/versioneer/tag_list_test.go#L356 not sure if we want to test is through kairos-agent too to make sure versioneer is consumed correctly. |
|
we still want the test for integration testing, but we should move into another test so we don't waste time spining up #2081 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will no longer work with versioneer so I commented the test. I'm wondering if the test should do something else though or if we remove it completely