Add target to transform kairos image into UKI #2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Itxaka
reviewed
Jan 24, 2024
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
jimmykarily
reviewed
Jan 25, 2024
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Itxaka
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new target requires to pass an existing kairos image, which means it's a two step proces e.g.
I first tried to have it in a single step but I'm not sure if it's possible since enki cannot access the local registry from Earthly. Even when using
WITH DOCKERthis is problematic because our uki building image is on fedora. We have to use fedora because Ubuntu does not have the latest packages e.g. ukify. However, Earthly complains that it doesn't know the distro, so considers it's a Debian and then proceeds unsuccessfully to try to install packages viaapt.Please let me know if I'm missing something here. And if it's not possible, then the question for me is really, about why we are doing this on Earthly since we are trying to move away from it for the Factory.
Relates to #870
Fixes #2170