Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Add SBOM artifacts to CI pipelines #998

Merged
merged 3 commits into from
Mar 2, 2023
Merged

🤖 Add SBOM artifacts to CI pipelines #998

merged 3 commits into from
Mar 2, 2023

Conversation

mudler
Copy link
Member

@mudler mudler commented Mar 1, 2023

What this PR does / why we need it: This PR introduces generated images SBOM to our releases

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #51

This PR introduces https://github.com/anchore/syft generating a SBOM which is attached at the end of the image build process. It also adds the SBOM to the uploaded artifacts (jobs and releases)

Example generated SBOM files: core-debian-v1.6.0-14-g193c740-dirty-sbom.s.zip

Signed-off-by: mudler <mudler@c3os.io>
Signed-off-by: mudler <mudler@c3os.io>
@netlify
Copy link

netlify bot commented Mar 1, 2023

Deploy Preview for kairos-io canceled.

Name Link
🔨 Latest commit 08ecb29
🔍 Latest deploy log https://app.netlify.com/sites/kairos-io/deploys/63ffc2b40852ea0008fa6ce3

@mudler mudler changed the title 🤖 Add SBOM 🤖 Add SBOM artifacts to CI pipelines Mar 1, 2023
Signed-off-by: mudler <mudler@c3os.io>
@mudler mudler mentioned this pull request Mar 1, 2023
2 tasks
@mudler mudler requested a review from a team March 1, 2023 21:27
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2023

Codecov Report

Merging #998 (08ecb29) into master (193c740) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #998   +/-   ##
=======================================
  Coverage   22.79%   22.79%           
=======================================
  Files          22       22           
  Lines        1610     1610           
=======================================
  Hits          367      367           
  Misses       1179     1179           
  Partials       64       64           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mudler mudler enabled auto-merge (squash) March 1, 2023 23:15
@@ -118,22 +118,6 @@ jobs:
with:
files: |
release/*
- run: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

ARG FLAVOR
COPY +syft/syft /usr/bin/syft
RUN syft / -o json=sbom.syft.json -o spdx-json=sbom.spdx.json
SAVE ARTIFACT /build/sbom.syft.json sbom.syft.json AS LOCAL core-${FLAVOR}-${VERSION}-sbom.syft.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt it be ${VARIANT}-${FLAVOR}-${VERSION} ? Not sure if we ever change the variant but in case we do that would trickle down to the naming here as well.

Copy link
Member

@Itxaka Itxaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, feel free to ignore

@mudler mudler merged commit 1460d77 into master Mar 2, 2023
@mudler mudler deleted the sbom branch March 2, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants