Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore grub artifacts to leap #553

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Restore grub artifacts to leap #553

merged 1 commit into from
Dec 1, 2023

Conversation

Itxaka
Copy link
Member

@Itxaka Itxaka commented Dec 1, 2023

tumbleweed seems to have some issues

@Itxaka
Restore grub artifacts to leap
5cc5452 
tumbleweed seems to have some issues

Signed-off-by: Itxaka <itxaka@kairos.io>
@Itxaka Itxaka requested a review from a team December 1, 2023 10:37
mauromorales
mauromorales approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change lgtm, but wasn't there an issue in leap about arm and amd ... that it used to ship all of them on the amd package or something like that?

@Itxaka Itxaka merged commit 023149f into kairos-io:main Dec 1, 2023
3 checks passed
@Itxaka Itxaka deleted the use_leap_grub_artifacts branch December 1, 2023 11:20
@Itxaka
Copy link
Member Author

Itxaka commented Dec 1, 2023

change lgtm, but wasn't there an issue in leap about arm and amd ... that it used to ship all of them on the amd package or something like that?

mostly that tumbleweed didnt ship both arches while leap did. But doesnt matter becuase now the build is done with templates depending on the arch

@Itxaka Itxaka mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauromorales mauromorales mauromorales approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Itxaka @mauromorales