Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix services tty output #557

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Fix services tty output #557

merged 2 commits into from
Dec 5, 2023

Conversation

Itxaka
Copy link
Member

@Itxaka Itxaka commented Dec 4, 2023

  • interactive installer: output was not connected to tty so it was impossible to answer any questions
  • reset: was not getting the output and taking over the tty so it got overwritten by other output. It could be stopped in the middle
  • installer: same as above but it could lead to stopping the install in the middle of it
  • recovery: same as above, QR code didnt even display

 - interactive installer: output was not connected to tty so it was
   impossible to answer any questions
 - reset: was not getting the output and taking over the tty so it got
   overwritten by other output. It could be stopped in the middle
 - installer: same as above but it could lead to stopping the install in
   the middle of it
 - recovery: same as above, QR code didnt even display

Signed-off-by: Itxaka <itxaka@kairos.io>
@Itxaka Itxaka requested review from jimmykarily and a team December 4, 2023 14:58
@Itxaka Itxaka changed the title Fix serivces tty output Fix services tty output Dec 4, 2023
Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jimmykarily
Copy link
Contributor

journal+console should still print to tty1 as long as tty1 is the default system console. In other words, the only way journal+console should be different from tty is that is should also log to journalctl. The reason I changed it in the first place was that in tests there was not way to get the installer's output since we couldn't read the tty1 (that's the only shown in the graphical window) and there was nothing logged to journalctl either.

If there something doesn't work, we should at least understand why it doesn't work before changing it back.

@Itxaka
Copy link
Member Author

Itxaka commented Dec 4, 2023

I don't get why it doesn't work, probably systemd is mangling the output somehow but it doesn't work as expected. You can try yourself by testing master with interactive install or recovery and see how it breaks the tty1 output. With this, which was the original setting from a long time ago, it doesn't.

But to make it work and not keep it broken we need to reverse this to a working state and then change it back to jornal+console as currently is a regression.

I wonder if the way we interact by Kairos agent is the reason, maybe we need to do changes there.

@jimmykarily
Copy link
Contributor

I'm fine to revert it for now to fix the regression. Let's open a new issue to investigate further and bring the change back properly.

@Itxaka
Copy link
Member Author

Itxaka commented Dec 4, 2023

umm, for the interactive installer at least, this is necessary to set the tty otherwise we got no control over the input/output with our current implementation.

maybe we could workaround the others somehow?

@Itxaka Itxaka merged commit bfa1341 into kairos-io:main Dec 5, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants