Fixes too many open files error #175 when grouping #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes you are awesome! Even though I'm not taking this pull request it lead me to the right solution. The for loop in the Grouper can close the DataPointGroups when it is done with them, there is no need to keep a reference to those further. |
|
Yea, I figured there would be a better way to implement the fix, I was getting quite turned around in there. Incidentally, as a seperate issue, when you use grouping you also get an error in the log because it tries deleting the grouper-* file twice. I wasn't sure which delete should be removed. |
|
Thanks again, I didn't realize it was getting called twice. Fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to the too many files open bug #175 #132 and others. When grouping the underlying DataPointGroup isn't being closed like it is in other scenarios.