Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 馃挕 remove deepmerge and dlv dependencies #39

Merged
merged 2 commits into from
Jan 15, 2020
Merged

refactor: 馃挕 remove deepmerge and dlv dependencies #39

merged 2 commits into from
Jan 15, 2020

Conversation

kaisermann
Copy link
Owner

No need for them anymore. We now flat the dicitonary partials on
addMessages

@kaisermann
refactor: 馃挕 remove deepmerge and dlv dependencies
eb3dbb6 
No need for them anymore. We now flat the dicitonary partials on
`addMessages`
@kaisermann kaisermann mentioned this pull request Jan 15, 2020
Open
@kaisermann kaisermann merged commit e02427d into master Jan 15, 2020
@kaisermann kaisermann deleted the refactor/flat-dicts branch January 15, 2020 16:59
@cibernox
Copy link
Contributor

Nice. The dlv package is not really a saving as the code you use to flatten is essentially the same, but removing the deepmerge one does save some space.

@kaisermann kaisermann mentioned this pull request Feb 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kaisermann @cibernox