Conditionally invalidate the displayLink #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyinghyrax
force-pushed
the
zombie-killing
branch
from
bde654b
to
e2e6d56
Compare
flyinghyrax
force-pushed
the
zombie-killing
branch
from
e2e6d56
to
007bab8
Compare
Don't invalidate the CADisplayLink on deinit unless the lazy display link instance was already initialized previously. - Closes kaishin#53
flyinghyrax
force-pushed
the
zombie-killing
branch
from
007bab8
to
d39002d
Compare
|
Thanks for the PR @mr-seiler! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't invalidate the displayLink if it was never initialized before the AnimatableImageView is deallocated.
For issue #53; this will conflict with PR #52. I can update it after #52 is closed or a maintainer can add these changes themselves; it's pretty straightforward.2016-04-10 - rebased after #52 and #55 were merged into master.