PRs for a bunch of issues #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of github.com:ray-g/erd-go: Update README.md
* upstream/master: Update README.md Update Dockerfile & README.md Update Makefile & templates_bindata Fix TravisCI more travis cleanup more cleanup, no more glide cleanup lint warnings and add integration test
|
@ray-g I'm sorry for replying late. GREAT PR! I will check it so please wait. |
|
LGTM! very good PR and easy to check. Thank you for your contribution!! I'll release it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kaishuu0123,
First thanks for bringing this great project.
I'm sorry to make such a big PR. I made a lot of changes the recent days. I should split it into small ones.
If you are not OK with it, I'll split it and submit PRs one by one.
What has been changed:
dotcommandcolorssegment, which can act as a named color palette?mark to the cardinality, showing the{0,1}, which exists in the BurntSushi ER formatThanks & Best Regards,
Ray