Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix overwriting relation attributes #6

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

sickhye
Copy link
Contributor

@sickhye sickhye commented Oct 15, 2018

fix missing initialization

test-data

job 1--1 job_lv_group {label: "job_lv_group_id"}
job 1--1 text {label: "text_name"}
job 1--1 text {label: "text_short_name"}
job 1--1 role {label: "role_id"}
job 1--1 job
job 1--1 job

before result

  job -- job_lv_group [arrowhead=noneotee,headlabel=<<FONT>1</FONT>>,label=<<FONT>role_id</FONT>>,arrowtail=noneotee,taillabel=<<FONT>1</FONT>>];
  job -- text [arrowhead=noneotee,headlabel=<<FONT>1</FONT>>,label=<<FONT>role_id</FONT>>,arrowtail=noneotee,taillabel=<<FONT>1</FONT>>];
  job -- text [arrowhead=noneotee,headlabel=<<FONT>1</FONT>>,label=<<FONT>role_id</FONT>>,arrowtail=noneotee,taillabel=<<FONT>1</FONT>>];
  job -- role [arrowhead=noneotee,headlabel=<<FONT>1</FONT>>,label=<<FONT>role_id</FONT>>,arrowtail=noneotee,taillabel=<<FONT>1</FONT>>];
  job -- job [arrowhead=noneotee,headlabel=<<FONT>1</FONT>>,label=<<FONT>role_id</FONT>>,arrowtail=noneotee,taillabel=<<FONT>1</FONT>>];
  job -- job [arrowhead=noneotee,headlabel=<<FONT>1</FONT>>,label=<<FONT>role_id</FONT>>,arrowtail=noneotee,taillabel=<<FONT>1</FONT>>];

after result

  job -- job_lv_group [arrowhead=noneotee,headlabel=<<FONT>1</FONT>>,label=<<FONT>job_lv_group_id</FONT>>,arrowtail=noneotee,taillabel=<<FONT>1</FONT>>];
  job -- text [arrowhead=noneotee,headlabel=<<FONT>1</FONT>>,label=<<FONT>text_name</FONT>>,arrowtail=noneotee,taillabel=<<FONT>1</FONT>>];
  job -- text [arrowhead=noneotee,headlabel=<<FONT>1</FONT>>,label=<<FONT>text_short_name</FONT>>,arrowtail=noneotee,taillabel=<<FONT>1</FONT>>];
  job -- role [arrowhead=noneotee,headlabel=<<FONT>1</FONT>>,label=<<FONT>role_id</FONT>>,arrowtail=noneotee,taillabel=<<FONT>1</FONT>>];
  job -- job [arrowhead=noneotee,headlabel=<<FONT>1</FONT>>,arrowtail=noneotee,taillabel=<<FONT>1</FONT>>];
  job -- job [arrowhead=noneotee,headlabel=<<FONT>1</FONT>>,arrowtail=noneotee,taillabel=<<FONT>1</FONT>>];

fix missing initialization
@kaishuu0123
Copy link
Owner

@sickhye

Thank you for you PR.
Sorry for the delayed response.

wait a little for merge since I'm checking it now.

@kaishuu0123 kaishuu0123 merged commit d122ec5 into kaishuu0123:master Nov 1, 2018
@kaishuu0123
Copy link
Owner

@sickhye Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants