Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] update TensorDicts instead of re-creating #56

Closed
fedebotu opened this issue May 27, 2023 · 1 comment
Closed

[Minor] update TensorDicts instead of re-creating #56

fedebotu opened this issue May 27, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@fedebotu
Copy link
Member

As spotted by @cbhua
Same as in TorchRL, reset updates incoming TensorDicts. So under our reset function, we can just call td.update

Reference

@fedebotu fedebotu added the enhancement New feature or request label May 27, 2023
@fedebotu fedebotu self-assigned this May 27, 2023
@fedebotu fedebotu changed the title [Feature] update TensorDicts instead of re-creating [Minor] update TensorDicts instead of re-creating Jun 9, 2023
@fedebotu
Copy link
Member Author

Note: this is a minor detail since update can only be done in reset and not step (in step, we need to re-create a TensorDict with the next key thus rendering update useless. We will follow up discussions in #72 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant