Repeat until #15
Merged
Repeat until #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, nobody said anything, so I'm merging it in. |
|
Apologies, I haven't had much free time recently. Thanks for adding this change - the code looks good, but I haven't had the time to test it out yet. |
|
No worries, it's not like a very major change or anything. Still need more tests for iterator var being a complex structure, or structure-in-structure access, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented
repeat-untilsupport, as specified in issue #18.The only difference I made is that I've chosen
_to designate iterator variable. This way it won't clash with any other "legitimate" field names (i.e.value), and, besides, many languages already use_for the purpose of anonymous iteration parameter (i.e. Perl uses$_, Scala uses_, Java 9 will use_).Looking for review, comments, etc.