-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Nim Compiler #170
[WIP] Nim Compiler #170
Conversation
|
|
||
override def fileHeader(topClassName: String): Unit = { | ||
outHeader.puts(s"# $headerComment") | ||
importList.add(s"../../../runtime/nim/kaitai") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this refers to the location of these files in test repo vs runtimes repo, but it won't be always true for production use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed RuntimeConfig.scala
and the relevant command line options (which exist for only ~half of the supported languages) but I am a little unsure about the approach here. Is it safe to say that it's simply a matter of having a saner default and adding a command line option for specifying the module's path?
Proposal:
- default = "kaitai" (root folder of user's project)
- command line option =
--nim-runtime-path
Looks good to me, thanks for this contribution! Merging in. |
I think this pattern is flexible and neat:
Chunks.fromFile("path/to/partial/file")