Fix constants generated in case of parent: false in Lua, Python and Ruby
#235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d Ruby - lua: false -> nil - python: False -> None - ruby: false -> nil Perl probably also affected by this but I don't known what to use instead of `0`
dgelessus
approved these changes
Feb 5, 2022
There was a problem hiding this comment.
Makes sense, thanks!
For Perl, my guess is that undef would be the right choice. That seems to be the closest thing to "null" that Perl has, and I think it's also what parent would be set to if you create a struct object without a parent. I don't know Perl very well though, so I'm not confident enough to make that change myself.
The fixes for the other affected languages are good, so I'll go ahead and merge this as-is. I'll leave the Perl fix to someone who knows the language better than I do :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perl probably also affected by this but I don't known what to use instead of
0