New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kstream constructor which uses std::string for initialization #43

Merged

generalmimon merged 1 commit into kaitai-io:master from N-Nagorny:kstream-string-ctor

Jun 14, 2021

Contributor

N-Nagorny commented Jun 14, 2021 •

edited by generalmimon

https://en.cppreference.com/w/cpp/io/basic_istringstream/basic_istringstream (3) takes const std::string& so it looks appropriate to take the same in kaitai::kstream constructor working with std::string.

Resolves kaitai-io/kaitai_struct#806


          Fix kstream constructor which uses std::string for initialization

fa28b50

generalmimon approved these changes

View reviewed changes

Member

generalmimon left a comment

Thanks!

generalmimon merged commit 71c9929 into kaitai-io:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment