Fixed bug when having UnknownTcpOption with zero data, avoid extracti… #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng sub array from the raw data. If the length is equal to 2 then it means there is no data, an empty data array will be created.
|
Thank you for your contribution! |
|
My pleasure Kaito. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug when having UnknownTcpOption with zero data, avoid extracting sub array from the raw data if the length is 2 then what have happened was that there is an attempt to get sub array with length zero (2-2, see the code)
If the length is equal to 2 then it means there is no data, an empty data array will be created.
I had a lot of TCP packets that throws exception due to this issue that eventually caused for increasing the memory, looks like a memory leak...