Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add protocol implementations for 4 icmpv6 types: #188

Closed
wants to merge 5 commits into from
Closed

add protocol implementations for 4 icmpv6 types: #188

wants to merge 5 commits into from

Conversation

leomaatEric
Copy link
Contributor

Below four Icmpv6 types are missing in current pcap4j, I've added the packet implementations and related update on properties and static factory for all of them:

  • HOME_AGENT_ADDRESS_DISCOVERY_REQUEST
  • HOME_AGENT_ADDRESS_DISCOVERY_REPLY
  • MOBILE_PREFIX_SOLICITATION
  • MOBILE_PREFIX_ADVERTISEMENT

please take a review of the code, it's all tested in my on-hand project and I just like to contribute it to this open source.

@leomaatEric
add protocol implementations for 4 icmpv6 types:
a0e84f4 
 - HOME_AGENT_ADDRESS_DISCOVERY_REQUEST
 - HOME_AGENT_ADDRESS_DISCOVERY_REPLY
 - MOBILE_PREFIX_SOLICITATION
 - MOBILE_PREFIX_ADVERTISEMENT

Signed-off-by: Leo Ma <leo.ma@ericsson.com>
@coveralls
Copy link

coveralls commented Aug 30, 2018 •
edited

Coverage Status

Coverage decreased (-0.01%) to 78.325% when pulling 5f5b415 on leomaatEric:v1 into 663c889 on kaitoy:v1.

@leomaatEric
Copy link
Contributor Author

@kaitoy

Have you checked this pull request?

kaitoy
kaitoy requested changes Nov 11, 2018
View reviewed changes
Copy link
Owner

@kaitoy kaitoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my late response, and thank you for your great contribution!
It is almost perfect, but needs some small changes.

pcap4j-core/src/main/java/org/pcap4j/packet/IcmpV6HomeAgentAddressDiscoveryReplyPacket.java Show resolved Hide resolved
pcap4j-core/src/main/java/org/pcap4j/packet/IcmpV6HomeAgentAddressDiscoveryReplyPacket.java Outdated Show resolved Hide resolved
pcap4j-core/src/main/java/org/pcap4j/packet/IcmpV6HomeAgentAddressDiscoveryRequestPacket.java Show resolved Hide resolved
pcap4j-core/src/main/java/org/pcap4j/packet/IcmpV6HomeAgentAddressDiscoveryReplyPacket.java Outdated Show resolved Hide resolved
pcap4j-core/src/main/java/org/pcap4j/packet/IcmpV6HomeAgentAddressDiscoveryRequestPacket.java Outdated Show resolved Hide resolved
pcap4j-core/src/main/java/org/pcap4j/packet/IcmpV6MobilePrefixAdvertisementPacket.java Outdated Show resolved Hide resolved
pcap4j-core/src/main/java/org/pcap4j/packet/IcmpV6MobilePrefixAdvertisementPacket.java Show resolved Hide resolved
pcap4j-core/src/main/java/org/pcap4j/packet/IcmpV6MobilePrefixAdvertisementPacket.java Outdated Show resolved Hide resolved
pcap4j-core/src/main/java/org/pcap4j/packet/IcmpV6MobilePrefixSolicitationPacket.java Show resolved Hide resolved
pcap4j-core/src/main/java/org/pcap4j/packet/IcmpV6MobilePrefixSolicitationPacket.java Outdated Show resolved Hide resolved
@leomaatEric
add protocol implementations for 4 icmpv6 types:
96d3a3a 
 - HOME_AGENT_ADDRESS_DISCOVERY_REQUEST
 - HOME_AGENT_ADDRESS_DISCOVERY_REPLY
 - MOBILE_PREFIX_SOLICITATION
 - MOBILE_PREFIX_ADVERTISEMENT

Signed-off-by: Leo Ma <leo.ma@ericsson.com>
@leomaatEric
Merge remote-tracking branch 'upstream/v1' into v1
da4eaf6
@leomaatEric
Merge branch 'v1' of https://github.com/leomaatEric/pcap4j into v1
6ea98be
@leomaatEric
fix merge conflict
5f5b415 
Signed-off-by: Leo Ma <leo.ma@ericsson.com>
@leomaatEric
Copy link
Contributor Author

@kaitoy

codes are updated following your comments, please review them.

kaitoy
kaitoy requested changes Dec 16, 2018
View reviewed changes
Copy link
Owner

@kaitoy kaitoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't merge any branches, rebase on the latest v1 branch instead.

pcap4j-core/src/main/java/org/pcap4j/packet/IcmpV6HomeAgentAddressDiscoveryReplyPacket.java Show resolved Hide resolved
pcap4j-core/src/main/java/org/pcap4j/packet/IcmpV6HomeAgentAddressDiscoveryReplyPacket.java Show resolved Hide resolved
pcap4j-core/src/main/java/org/pcap4j/packet/IcmpV6HomeAgentAddressDiscoveryReplyPacket.java Show resolved Hide resolved
pcap4j-core/src/main/java/org/pcap4j/packet/IcmpV6HomeAgentAddressDiscoveryReplyPacket.java Show resolved Hide resolved
pcap4j-core/src/main/java/org/pcap4j/packet/IcmpV6HomeAgentAddressDiscoveryReplyPacket.java Show resolved Hide resolved
pcap4j-core/src/main/java/org/pcap4j/packet/IcmpV6MobilePrefixAdvertisementPacket.java Show resolved Hide resolved
pcap4j-core/src/main/java/org/pcap4j/packet/IcmpV6MobilePrefixAdvertisementPacket.java Show resolved Hide resolved
pcap4j-core/src/main/java/org/pcap4j/packet/IcmpV6MobilePrefixSolicitationPacket.java Show resolved Hide resolved
pcap4j-core/src/main/java/org/pcap4j/packet/IcmpV6MobilePrefixSolicitationPacket.java Show resolved Hide resolved
pcap4j-core/src/main/java/org/pcap4j/packet/IcmpV6MobilePrefixSolicitationPacket.java Show resolved Hide resolved
@leomaatEric
Copy link
Contributor Author

leomaatEric commented Dec 17, 2018 •
edited

Okay. to make the commit clearer, I will create a new push request based on latest v1 branch, then close this one.

the new created pull request with clean code is at #196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaitoy kaitoy kaitoy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leomaatEric @coveralls @kaitoy