Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Platform specific default values for address families and DLT_RAW #78

Closed
wants to merge 5 commits into from
Closed

Platform specific default values for address families and DLT_RAW #78

wants to merge 5 commits into from

Conversation

michaelkoetter
Copy link
Contributor

Also, when default values are used, this is now logged on 'INFO' level (was 'WARN').
This should fix #75

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 70.235% when pulling 9262843 on michaelkoetter:issue-75-warning-on-startup into 18f39f5 on kaitoy:v1.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 70.222% when pulling 5057489 on michaelkoetter:issue-75-warning-on-startup into 18f39f5 on kaitoy:v1.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 70.276% when pulling 8156502 on michaelkoetter:issue-75-warning-on-startup into 18f39f5 on kaitoy:v1.

@kaitoy
Copy link
Owner

kaitoy commented Dec 7, 2016

Thank you for your PR. I will take a look at it.

kaitoy
kaitoy requested changes Dec 20, 2016
View reviewed changes
Copy link
Owner

@kaitoy kaitoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert indent changes on Pcap4jPropertiesLoader.java? I can't see proper diffs.

@kaitoy
Copy link
Owner

kaitoy commented Dec 24, 2016

I fixed the indent and merged your commits manually.
Thank you for your contribution.

@kaitoy kaitoy closed this Dec 24, 2016
@kaitoy kaitoy mentioned this pull request Dec 24, 2016
Closed
@kaitoy kaitoy reopened this Dec 28, 2016
@kaitoy kaitoy closed this Dec 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaitoy kaitoy kaitoy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning on startup
3 participants
@michaelkoetter @coveralls @kaitoy