replace react proptypes #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kaivi Can we please get this merged? The package is breaking while using newer versions of React (v16.2). |
hwhh
approved these changes
Feb 28, 2018
|
@kaivi ? |
AlexisWilke
added a commit
to AlexisWilke/ReactInlineEdit
that referenced
this pull request
Oct 6, 2018
…id potential conflicts.)
|
I tested this pull (#41) and it works great for me. Everything is as expected and no problems with the props. I created my own version so I can use it in my project, cleanly. It's here: https://www.npmjs.com/package/react-edit-inline2 And on GitHub, I have a fork here: https://github.com/AlexisWilke/ReactInlineEdit I do not intend to support my fork, but it could be a better starting point for your own in case you like this inline edit widget. Note that at this time there are 81 forks, so there are possibly others of interest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing type checking with proptypes instead of React.proptypes https://reactjs.org/docs/typechecking-with-proptypes.html