Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality of life fixes #9

Merged
merged 6 commits into from
Jan 19, 2016
Merged

Quality of life fixes #9

merged 6 commits into from
Jan 19, 2016

Conversation

masad-frost
Copy link
Contributor

Nothing major, just quality of life fixes.

Edit:

Take this pull as a proposal, you don't have to add all of these things, but some of them are warranted.

Here's a list of things that need(ed) consideration, in my opinion. In order of importance:

  1. Consistent style (and basic lint stuff)
    • spacing
    • spaces after if
    • let instead of var
    • dangling commas
    • lower case functionName
    • life-cycle methods before others, followed by render.
  2. Using defaultProps and getting rid of prop || defaultValues
  3. Class properties (since stage 0 is being utilized)
    • state = { ... };
    • get rid of binding and use property initializers
    • other initialization stuff in componentWillMount as opposed to constructor, I'm not sure about the science behind using which, but it felt more natural to drop the constructor and use react methods.

@kaivi kaivi merged commit d46d8fa into kaivi:master Jan 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants