-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve codecs #33
Merged
Merged
Improve codecs #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… casing optimizations on CqlPrimitiveDecoder
…ssible working around the limitations of Magnolia's derivation mechanism interfering with variance
…ve data if not required) * Add either and absolve for all levels of Decoders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Divide codecs into 3 parts:
UdtValue
and materialization of any typeA
that can be derived using 2This separation allows us to eliminate writing down
derive
when it comes to codecs for any structure (be it aRow
or aUdtValue
).Special-casing optimizations have been done on Primitive codecs in order to avoid using the generic
get
orset
method whenever possible which results in a lookup to the internal driver codec registry.For example:
Add coverage + coveralls integration into the builds
Improve error messages giving users the opportunity to see exactly what went wrong via
DecoderException
and the structure that failed to decode.For example:
Improve compositionality of codecs