Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit plain css @import directives #139

Closed
kaj opened this issue May 6, 2022 · 0 comments · Fixed by #137
Closed

Limit plain css @import directives #139

kaj opened this issue May 6, 2022 · 0 comments · Fixed by #137

Comments

@kaj
Copy link
Owner

kaj commented May 6, 2022

Plain css @import rules is only allowed on a few condtions. Currently rsass considers any unresolved @import a plain css import, but in many cases it should signal an error instead.

@kaj kaj changed the title Limit plain css @imports Limit plain css @import directives May 6, 2022
kaj added a commit that referenced this issue May 9, 2022
Fixes #139.

Plain css `@import` rules is only allowed on a few condtions.
Currently rsass considers any unresolved `@import` a plain css import,
but in many cases it should signal an error instead.

https://sass-lang.com/documentation/at-rules/import#plain-css-imports
kaj added a commit that referenced this issue May 9, 2022
Fixes #139.

Plain css `@import` rules is only allowed on a few condtions.
Currently rsass considers any unresolved `@import` a plain css import,
but in many cases it should signal an error instead.

https://sass-lang.com/documentation/at-rules/import#plain-css-imports
kaj added a commit that referenced this issue May 9, 2022
Fixes #139.

Plain css `@import` rules is only allowed on a few condtions.
Currently rsass considers any unresolved `@import` a plain css import,
but in many cases it should signal an error instead.

https://sass-lang.com/documentation/at-rules/import#plain-css-imports
kaj added a commit that referenced this issue May 14, 2022
Fixes #139.

Plain css `@import` rules is only allowed on a few condtions.
Currently rsass considers any unresolved `@import` a plain css import,
but in many cases it should signal an error instead.

https://sass-lang.com/documentation/at-rules/import#plain-css-imports
kaj added a commit that referenced this issue May 14, 2022
Fixes #139.

Plain css `@import` rules is only allowed on a few condtions.
Currently rsass considers any unresolved `@import` a plain css import,
but in many cases it should signal an error instead.

https://sass-lang.com/documentation/at-rules/import#plain-css-imports
kaj added a commit that referenced this issue May 14, 2022
Fixes #139.

Plain css `@import` rules is only allowed on a few condtions.
Currently rsass considers any unresolved `@import` a plain css import,
but in many cases it should signal an error instead.

https://sass-lang.com/documentation/at-rules/import#plain-css-imports
@kaj kaj closed this as completed in #137 May 15, 2022
kaj added a commit that referenced this issue May 17, 2022
Released 2022-05-17 (On the Norwegian Constitution day 🇳🇴).
Progress: 4331 of 6523 tests passed in dart-sass compatibility mode.

* Update minimum supported rust version to 1.49.0 (from 1.45.2).
* `SourceFile.parse()` now returns a `Result<Parsed>` rahter than a
  `Result<Vec<sass::Item>>`, and `Format::write_root` now takes a
  `Parsed` (PR #140).
* `FsFileContext::file` is replaced by `FsFileContext::for_path`,
  which initializes a file context and loads a file from it (PR 137).

* Hopefully improved relative file finding on windows (PR #137).
* Plain css `@import` rules is only allowed [on a few
  condtions](https://sass-lang.com/documentation/at-rules/import#plain-css-imports),
  in other cases an error is reported (Issue #139, PR #137).
* Rsass can now parse (some) plain css as well as scss.  Css files can
  be referenced in `@use` and `@import` directives, as well as in the
  `meta.load-css` mixin (PR #140).
* Make the `calc(...)` function signal an error when args are known to
  be invalid css (PR #138).
* Change `map.deep-merge` to match recent change in dart sass.
* Minor fix in whitespace around at-rules.
* Instrumented attempted file loading with `tracing` (PR #137).
* Fix a typo in LICENSE (Issue #136).
* Update sass-spec test suite to 2022-05-10.
* Make rust version of sass-spec more directory-aware (which fixes one
  of 5825 tests).
* Use a crates badge that actually works.

Thanks to @jonassmedegaard for #136, and to @fasterthanlime for
reporting the problem that #137 attempts to fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant