Attempt more path improvements #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work some more with paths as `Path` and use `join` for joining a local name with the base paths. The local parts are still strings that may contain `/` as separator, but base is properly used as OS-native paths.
kaj
added a commit
that referenced
this pull request
May 27, 2022
Released 2022-05-27. Progress: 4350 of 6552 tests passed in dart-sass compatibility mode. * Use platform-dependent `path.join` for putting the local part after a base path, seems to make slash-separated strings ok as the joined part. (PR #144, issue #133) * Update sass-spec test suite to 2022-05-20. Thanks to @fasterthanlime for reporting and testing.
kaj
added a commit
that referenced
this pull request
May 31, 2022
Released 2022-05-27. Progress: 4350 of 6552 tests passed in dart-sass compatibility mode. * Use platform-dependent `path.join` for putting the local part after a base path, seems to make slash-separated strings ok as the joined part. (PR #144, issue #133) * Update sass-spec test suite to 2022-05-20. Thanks to @fasterthanlime for reporting and testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work some more with paths as
Pathand usejoinfor joining a localname with the base paths. The local parts are still strings that may
contain
/as separator, but base is properly used as OS-nativepaths.
May fix #143 ?