Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

static file cant start with a number #82

Closed
Aedius opened this issue Jun 23, 2020 · 1 comment · Fixed by #132
Closed

static file cant start with a number #82

Aedius opened this issue Jun 23, 2020 · 1 comment · Fixed by #132
Labels
bug

Comments

@Aedius
Copy link

Aedius commented Jun 23, 2020

In the function add_static, the variable rust_name start with the name of the file, so it breaks.

It's not a big deal, but i thing it's worth mentioning.
@kaj
Copy link
Owner

kaj commented Jul 5, 2020 •
edited

True. It could be fixed by adding a constant string before the name (so foo.jpg still becomes foo_jpg but 17.jpg becomes static_17_jpg). Or it could just be a line in the documentation stating that static files names starting with numbers is not allowed.

@kaj kaj added the bug label Jul 5, 2020
@kaj kaj mentioned this issue Jul 18, 2023
Merged
@kaj kaj closed this as completed in #132 Jul 18, 2023
kaj added a commit that referenced this issue Jul 22, 2023
@kaj
Release 0.17.0 -- 2023-07-22
b4a42d1 
* Added a check that no more than one of the http-types, mime02, or
  mime03 features are enabled (PR #124).  Thanks @rustafarian-dev.
* Changed the writer type from `W: &mut Write` to just `W: Write` (PR #125).
  Thanks @kornelski!
* Fixed handling of `MULTI_WORD_CONSTANTS` in templates (Issue #129, PR #130).
  Thanks @wezm!
* More ways to create a working rust symbol name from a "strange"
  static file name.  Illegal characters are replaced by `_`, and if
  the file name starts with a number it is prefixed with `n` (Issue
  #82, PR #132).  Thanks @Aedius for reporting!
* Fixed more clippy lints (PR #123, #127).  Thanks @vbrandl!
* Updated `rsass` to 0.28.0 and `itertools` to 0.11.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle bad file names. kaj/ructe
2 participants
@kaj @Aedius