Feature/cli

[kajahno]

There's a few race conditions, but I've done the minimum required for everything function.

This is how the interface looks:

npm run start -- stats-daily --help

> elprimobot@1.0.0 start
> node app.js "stats-daily" "--help"

discord client is ready
elprimobot stats-daily

Sends Discord users daily chat activity stats

Options:
      --help     Show help                                             [boolean]
      --version  Show version number                                   [boolean]
  -v, --verbose  Run with verbose logging                              [boolean]

I've tested everything. All working

[nramirez]

out of curiosity, what are some of the race conditions?

[kajahno]

@nramirez I've created the following issue for the refactor #58.

I think it's going to require changing quite a few things for this, for example, to pass the discord client around.

One of the race conditions is that sometimes when the client initializes and we immediately call the discord APIs that have the .channel, it wouldn't grab anything and would raise an exception instead.

[nramirez]

That race condition won't happen if you call the client like this => 996ea55#diff-fda8f0e13abe3d5c5685ad895fa528dd6067c41b66b6ebc6d1de71ca9a704d8dR55

I agree you can refactor later, but given that my changes now landed you can rebase and reuse the new builder.

[nramirez]

LGTM, sure thing we can improve this in the next follow-ups.
I would recommend rebasing to avoid the dup with the client creation.

[vetom]

Agree with Naz's comments, well done!