Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max HP Modifier updates the Max HP insead of than Temp Max HP #1158

Open
Janders797 opened this issue Aug 8, 2024 · 4 comments
Open

Max HP Modifier updates the Max HP insead of than Temp Max HP #1158

Janders797 opened this issue Aug 8, 2024 · 4 comments
Labels
Milestone

Comments

@Janders797
Copy link

When HP are temporarily modified on DNDBeyond (Aid, Specter, etc), this should change the Temp Max HP, not adjust the Maximum Hitpoints.
DBDBeyond:
image
Foundry:
image

@Janders797 Janders797 added the bug Something isn't working label Aug 8, 2024
@kakaroto kakaroto added invalid This doesn't seem right and removed bug Something isn't working labels Aug 8, 2024
@kakaroto
Copy link
Owner

kakaroto commented Aug 8, 2024

That's incorrect, temp HP is not the same as HP. You can literally see in your first screenshot how "Temp HP" is marked as 0 in D&D Beyond.
If you get hit, you lose the temp HP but cannot regain it, while your hit point maximum being increased by Aid would allow you to heal back to the new maximum for the duration of the spell. Spectre monster would lower your hitpoint maximum, that doesn't make it negative temp HP either.
I think you misunderstand the concept of temp HP and how modifying a character's maximum HP works in D&D 5e.

@kakaroto kakaroto closed this as completed Aug 8, 2024
@Janders797
Copy link
Author

It shouldn't modify the Max HP, nor the Temp HP, but the box under it, called Temp Max HP. Which it clearly didn't.

@Janders797
Copy link
Author

This is what it's supposed to look like:
image

@kakaroto
Copy link
Owner

Ah, I see, thanks for the clarification, I misunderstood the original request, and I hadn't understood the "Temp Max HP" (understood it as "Max Temp HP" which doesn't make sense, lol). I think it was a recent addition to the dnd5e system (at least, it wasn't a thing when I implemented the original hp syncing feature.

@kakaroto kakaroto added FVTT and removed invalid This doesn't seem right labels Aug 10, 2024
@kakaroto kakaroto added this to the 2.10.0 milestone Aug 10, 2024
@kakaroto kakaroto reopened this Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants