Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix long id in gitalk #508

Merged
merged 1 commit into from
Sep 7, 2021
Merged

fix long id in gitalk #508

merged 1 commit into from
Sep 7, 2021
+1 −1

Conversation

duval1024
Copy link
Contributor

decode uri for gitalk

fixes #507

@duval1024
Copy link
Contributor Author

duval1024 commented Sep 5, 2021 •
edited

Please check this pull request. It is my first pull request. I am not sure if it is correct.

Thank you very much! @kakawait

@kakawait
Copy link
Owner

kakawait commented Sep 6, 2021

The problem with decodeURI is that it will work with your use case but not for all.

The main problem is that id must be unique and not more 50 chars.

What we can do in place of decodeURI is using hash function like md5 or sha1

Can you please check?

@duval1024
Copy link
Contributor Author

I agree with you. The best way to fix it is md5 or sha1. I will try later

@duval1024
Copy link
Contributor Author

@kakawait hi，I have changed it to md5 function. Please check. Thx~

@duval1024 duval1024 changed the title decode uri for gitalk fix long id in gitalk Sep 7, 2021
@kakawait kakawait added the bug Something isn't working label Sep 7, 2021
@kakawait kakawait added this to the 0.5.2-BETA milestone Sep 7, 2021
@kakawait kakawait merged commit 2dd1e58 into kakawait:develop Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.5.2-BETA
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@duval1024 @kakawait