WIP (Blocked): Indentation guides #720
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
igor-ramazanov
force-pushed
the
feature/indent-guides
branch
from
5d1f4da
to
e953935
Compare
Adds `IndentGuidesParams` which will be receved from Kakoune.
Adds new `kak-lsp/indent-guides` request type and calling unimplemented function.
Implements the `fn indent_guides(...)` function.
Adds KakScript code with indent guides related options and commands.
igor-ramazanov
force-pushed
the
feature/indent-guides
branch
from
dcc1e28
to
973b9f1
Compare
|
@krobelus Answering your comment in a previous PR: #711 (comment) I like the idea with specifying only start of the indent. In my opinion, it's good to mirror the existing combination of It'll be intuitive to understand and use through an analogy, I think. Not exactly what you proposed, but a development of your idea. Hopefully, this similarity can also help in implementation. |
|
Ah, I've forgot that The only API we have to replace/render characters is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of the #711 moved to the repo.
Adds indentation guides highlighting the scope of the functions/methods/classes/etc.
The implementation depends on the document symbols LSP API.
lsp-indent-guides-(enable|disable) {buffer|global|window}.IndentGuideandIndentGuideFocused, defaultscommentandMatchingChar.Picks the last one if the scope is deeper than the amount of characters.
lsp_indent_guides_characters, defaults to│ ┆ ┊ ⸽.lsp_indent_guides_skip, defaults to1.Screenshot before:
Screenshot after:
NOTE: As you see in the screenshot it shifts the indended code to the right. This is an issue which needs to be fixed within Kakoune itself to allow highlighters to render on empty places, see the comment.