Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-4: fix for user attach to group #7

Closed
wants to merge 1 commit into from
Closed

GH-4: fix for user attach to group #7

wants to merge 1 commit into from

Conversation

rooty0
Copy link
Contributor

@rooty0 rooty0 commented Mar 4, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 85.092% when pulling 7c5aa5b on rooty0:bug/group-role-attach into e37b88d on kakwa:master.

@kakwa
Copy link
Owner

kakwa commented Mar 16, 2017

Hello,

First of all, thank you for your other PRs.

I haven't fixed this issue exactly like you proposed (I have the feeling that the re extract will bring some bugs in the future).

I've done it in following commit:
3fd6dce

@rooty0
Copy link
Contributor Author

rooty0 commented Mar 17, 2017

@kakwa, looks good, thanks!

@rooty0 rooty0 closed this Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rooty0 @coveralls @kakwa