Skip to content

Add digital tones#39

Merged
kalafut merged 4 commits into
kalafut:masterfrom
jboolean:digital-code
Mar 25, 2024
Merged

Add digital tones#39
kalafut merged 4 commits into
kalafut:masterfrom
jboolean:digital-code

Conversation

@jboolean

@jboolean jboolean commented Mar 5, 2024

Copy link
Copy Markdown
Contributor

Add the 100 Hz digital tone, which is conspicuously missing from the simulation.

Well, most of it. Getting the values for DUT1 and leap seconds seems like more effort than it's worth.

Based on the definition on Wikipedia https://en.wikipedia.org/wiki/WWV_(radio_station)#Interpretation

App.Recording.20240304.2100.mp4

I noticed that the second ticks that are on the deployed site don't seem to play when run locally, maybe the code in production is different from that on master? I don't think that's related to my changes 🤷

@kalafut

kalafut commented Mar 5, 2024

Copy link
Copy Markdown
Owner

Thanks for the extensive PR! I'll take a look at it soon.

which is conspicuously missing from the simulation.

I actually recall specifically not doing it because:

  • I'd been futzing with V1 forever and just needed to ship it
  • My skimming over the encoding was completely wrong, apparently. I'd thought that the encoding was a much higher rate and would need to be in the JS (i.e. couldn't be generated), and that would be at odds with what I built so far. Skimming over your PR I see how it is done and can fit the current model.

I noticed that the second ticks that are on the deployed site don't seem to play when run locally

I'll take a look. There have been some user-contributed sound updates over the years and something could have gotten out of sync when I was redeploying.

Thanks again!

@kalafut kalafut left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic all looks good, but can you remove the changes to dist/ and clips/? I'll be regenerating everything (both JS and MP3) before publishing so these changes would just bloat the repo.

Thanks!

Comment thread src/scheduler.js

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there are now some merge conflicts with this. Not your fault... I got around to applying 5 years of JS updates.

@kalafut

kalafut commented Mar 25, 2024

Copy link
Copy Markdown
Owner

This works great. Thank you!

BTW, I'm mostly away from computer for a few days and will get things deployed soon.

@kalafut kalafut merged commit 83cea9d into kalafut:master Mar 25, 2024
@jboolean

Copy link
Copy Markdown
Contributor Author

Sorry, I didn't have time to rebase these past few weeks. Thanks for taking care of the conflicts.

@kalafut

kalafut commented Mar 25, 2024

Copy link
Copy Markdown
Owner

It's live now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants