New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add digital tones #39
Conversation
Thanks for the extensive PR! I'll take a look at it soon.
I actually recall specifically not doing it because:
I'll take a look. There have been some user-contributed sound updates over the years and something could have gotten out of sync when I was redeploying. Thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic all looks good, but can you remove the changes to dist/
and clips/
? I'll be regenerating everything (both JS and MP3) before publishing so these changes would just bloat the repo.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there are now some merge conflicts with this. Not your fault... I got around to applying 5 years of JS updates.
These will be rebuilt anyway.
This works great. Thank you! BTW, I'm mostly away from computer for a few days and will get things deployed soon. |
Sorry, I didn't have time to rebase these past few weeks. Thanks for taking care of the conflicts. |
It's live now. |
Add the 100 Hz digital tone, which is conspicuously missing from the simulation.
Well, most of it. Getting the values for DUT1 and leap seconds seems like more effort than it's worth.
Based on the definition on Wikipedia https://en.wikipedia.org/wiki/WWV_(radio_station)#Interpretation
App.Recording.20240304.2100.mp4
I noticed that the second ticks that are on the deployed site don't seem to play when run locally, maybe the code in production is different from that on master? I don't think that's related to my changes 馃し