Dragging tabs to other (or new) group can be unreliable, and "move to other group" context menu isn't always shown

[GoogleCodeExporter]

When using multiple tab handler, attempts to drag multiple tabs between groups 
can be extremely unreliable or simply persist to fail (typically an attempt to 
drag does nothing more than change the tab selection), and the "move to other 
group>" context menu doesn't always show if multiple tabs are selected (which 
would allow it to be done without drag&drop).

More info available if needed.

Original issue reported on code.google.com by Stilezy on 12 Jun 2013 at 2:52

[GoogleCodeExporter]

Original comment by Stilezy on 18 Jun 2013 at 11:07

• Added labels: TGM-1issues

[GoogleCodeExporter]

Original comment by Stilezy on 18 Jun 2013 at 11:11

• Added labels: Milestone-TGM1_issues
• Removed labels: TGM-1issues

[GoogleCodeExporter]

My observations from experiencing this behavior:
- Trying to move the currently selected tab will not work and most likely just 
shift tab focus to the next or previous tab (as explained above).
- Work around: unselected tabs can be moved around as usual. This is the only 
work around I have found and may offer hints to the underlying error. It also 
works to get tabs to realign back into place when they refuse to do so while 
reorganizing tabs within a group.

So far, restarting the browser seems to be the only way to get the context menu 
working again.
Hope the information is somewhat useful.

Original comment by magius....@gmail.com on 25 Jun 2013 at 1:50

[GoogleCodeExporter]

Dragging a tab to another group makes tabs in that group and the original one 
to be messed up and unelectable. Tabs appear overlapped and with gaps between 
some. You can't get them back to normal without opening a new tab and dragging 
that one to a new position or sometimes repositioning a background tab.


Using the latest version from Project Home page. Is this being fixed by you 
guys? Or are we just going to have to keep doing the work around until TGM 
completely becomes incompatible? 

Original comment by ziip...@gmail.com on 3 Jul 2013 at 4:55

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Its being fixed, but Im still thinking how to fix it. 
Currently TGM can move tabs perfectly from one group to another, when the tab 
is not moving.

The problem we have here is that, when we are moving a tab to a group, the tab 
is moving in its group trying to get a position, but the tab never gets it and 
is never set in a final place between other tabs (its like flying in nowhere). 
It like saying that it doesnt get a final index position. This issue could have 
been caused by many core changes made in Firefox.

There are two listener functions which are the ones where must look at and are 
fired at the same time:
1. onDrop(tab) - when its moved in its group, and dropped in the same group.
2. onDrop(tab, toGroup) - when its moved in its group, but its finally dropped 
to another group.

The ideal solution would be to fire the second function onDrop(tab, toGroup) 
when the first function has ended. That way we could make sure that the tab has 
already received a place between two tabs, and could be finally sent to another 
group without causing an unexpected behavior while moving it. I need to guess 
how to do it, since the solution is really simple.

Original comment by miguelro...@gmail.com on 7 Jul 2013 at 6:31

[GoogleCodeExporter]

Just fixed it with one line of code lol :)
setTimeout(function() { 
TabGroupsManager.allGroups.moveTabToGroupInSameWindow(tab,event.target.group,eve
nt.ctrlKey); }, 100);

Did the solution posted above, I was lucky since the onDrop(tab, toGroup) 
contains two lines of code which stop the propagation of the original event 
onDrop, and makes the tab to go back to its original position. This is perfect 
since the tab isnt anymore in a flying state, and can be moved perfectly :)

Going to test with multiple tab selection and group selection.

Original comment by miguelro...@gmail.com on 7 Jul 2013 at 7:35

[GoogleCodeExporter]

The fix works perfectly with Multiple Tab Handler extension. I didnt even know 
that extension has been created lol :P

Testing stability with groups, I dont know how to send a Group into another 
Group. Is it possible with TGM?

Original comment by miguelro...@gmail.com on 7 Jul 2013 at 7:42

[GoogleCodeExporter]

You can't send groups into groups, 99% certain. Used to edit wiki for Axel so 
pretty familiar with most things he implemented. 

Awesome you worked it out and fixed! Can  we download this now or later? 

Original comment by ziip...@gmail.com on 13 Jul 2013 at 1:50

[GoogleCodeExporter]

Hi ziiplox, you may try the prerelease version .002 with those fixes, however 
have in mind that its a prerelease version, which may contain new bugs and 
could make your session or some groups to be lost after installing the new 
version.
If you still want to try it out, I would recommend you to make a full backup of 
all your tabs, history and TGM session, and then proceed to install this new 
version, available in the prerelease folder:
http://tabgroupsmanager.googlecode.com/svn/prereleases/addon-2013.07.07.002-fx.x
pi

Original comment by miguelro...@gmail.com on 15 Jul 2013 at 9:05

[GoogleCodeExporter]

> Testing stability with groups, I dont know how to send a Group into another 
Group. Is it possible with TGM?

Not that I know of. The issue relates to selecting multiple tabs (with Multiple 
Tab Handler active) and either dragging them to a different group, or using the 
right-click context menu item "Move to group > (list of groups)". It usually 
fails or is unreliable, and for the second of these, it fails because the 
context menu item isn't shown.

Original comment by Stilezy on 27 Jul 2013 at 3:12

[GoogleCodeExporter]

Hi,

We'll probably be revisiting this one as part of a refactoring effort.  
Ziiplox, please consider getting in touch with us.  We're going to try rolling 
some new documentation this upcoming week.  Typically, any real-time work 
happens in #tabgroupsmanager on irc.mozilla.org.

-- John

Original comment by tgmj...@gmx.com on 9 Sep 2013 at 3:57

• Added labels: Milestone-104.0
• Removed labels: Milestone-TGM1_issues

[GoogleCodeExporter]

Original comment by tgmj...@gmx.com on 9 Sep 2013 at 4:01

• Changed state: Accepted

[GoogleCodeExporter]

Using the beta now it's great! Yay finally got working drag into groups. Felt 
so limiting not being able to drag to groups. 

Original comment by ziip...@gmail.com on 20 Nov 2013 at 11:16

[GoogleCodeExporter]

hmmm damn has the original wiki been completely lost? Or has someone still got 
a backup? That would have been a great starting point. I used Axels own 
documentation / updates and did my best to fix the broken English. 

Original comment by ziip...@gmail.com on 20 Nov 2013 at 11:21

[GoogleCodeExporter]

Fixed in first beta, closing the issue.

Original comment by miguelro...@gmail.com on 21 Oct 2014 at 6:56

• Changed state: Fixed