Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for firefox/pale moon 24? #90

Open
GoogleCodeExporter opened this issue Mar 14, 2015 · 7 comments
Open

support for firefox/pale moon 24? #90

GoogleCodeExporter opened this issue Mar 14, 2015 · 7 comments

Comments

@GoogleCodeExporter
Copy link

I noticed you removed support for firefox versions below 25. I can still get it 
to work by changing the version number back in install.rdf. I've used it for a 
few browser sessions, but it still seems to work okay for me. 

This version reintroduced the bug where tabs from other groups show up during 
startup. Just an annoying bug that can be fixed by clicking another group and 
then back again each time you start the browser up. 

Multi-row tabs is working in this version which is great. I can't use the 
previous versions because it has a bug with multi-row tabs. Before this 
version, I had to revert back to addon-2013.04.10.001-fx.xpi since I had tab 
mix plus with 2 rows of tabs. Tabgroups manager conflicts with multi-row.

Tab group colors for other groups still doesn't work.

I haven't tried restoring from a session yet since I haven't crashed yet. And I 
don't want to risk having my tabs be out of order once I restore them.

Overall, this version seems to be working better than versions 002-004 on my 
setup with session manager and tab mix plus because multi-row is fixed. This 
addon was originally created before 25+. Not only that but firefox 25+ changed 
addon compatibility quite a bit. Is there a reason why older versions were 
removed? Was it because version 005 changed the code to fit more along with 
firefox 25+?


System Info:
What version of TabGroups Manager are you using?
- addon-2014.12.21.005-fx

What Operative System are you using? 32 or 64 bits?
- windows 7 64 bit home premium

What version of Firefox are you using?
- pale moon 24.7.2 (firefox fork version 24)

Are you using any other tab extension like Colorfull tabs, Multiple Tab
Handler, TabMix Plus..?
- tab mix plus 0.4.1.5.2
- session manager 0.8.0.8

Original issue reported on code.google.com by swmaxi...@gmail.com on 6 Jan 2015 at 4:28

@GoogleCodeExporter
Copy link
Author

Yes of course there is a reason to remove support for Fx<25. There is a failure 
message "tab.group is not defined" at startup since Fx25+ internal changes. In 
fact this means that we need more time to get this available.  We added a 
promise here to wait until this is ready and this is not available on Fx<25.

Of course it would be easy to check for firefox version at runtime and act as 
needed, but i see no good reasons to use an old Firefox version. Suspect your 
reason is to use old 24.7.2 is, with 25 was the GUID for Palemoon changed, 
which results in more addon compatibility problems + some addons are not yet 
working. 

The more needed fix would be to add palemoon guid to install.rdf. But who shall 
test Palemoon here?  Also i am not sure if Fx24 == Palemoon24 so that all above 
24.7.2 is again a questionmark.

Regarding the reintroduced bug where tabs from other groups show up during 
startup....I have this never seen. This would mean that the hidden attribute 
was not correct settled at startup. Please check if you can reproduce this with 
actual firefox.

Original comment by micha.go...@arcor.de on 6 Jan 2015 at 7:56

@GoogleCodeExporter
Copy link
Author

[deleted comment]

@GoogleCodeExporter
Copy link
Author

Sorry if I say anything wrong, I typed in a bunch of information and it got 
lost when I clicked a link and forgot what I put in. I'm retyping what I can 
recall from my memory.

Pale moon is stated to be compatible with Fx 24 addons. And from my experience, 
it seems be to compatible with Fx24. I didn't seem to have any problems with 
the 44 addons I have installed. But then again, I don't know what goes on 
behind the scenes on the browser end. Pale moon 25 definitely gave me problems 
though. Anyways, moving on,

I think I was wrong about the bug being reintroduced. I said that because I was 
having issues with multi-row on the previous versions. Because of the multi-row 
bug, I didn't get a chance to see if it got fixed, so I thought it got fixed.

For demonstration purposes, I'll be showing you what the bug looks like:
http://youtu.be/4uGTNoy1ckc

What happens is that tabs from other groups show up in my current group when I 
first startup the browser session. The tabs from other groups push my tab to 
the right and my starting tab ends up in the middle of the tabbar. When I click 
the other tabs, it goes to that tab's group. Only when I select another group 
does the issue get fixed. Switching to another group and back puts all the tabs 
back into the correct group.

I tried setting browser.sessionstore.restore_hidden_tabs to false and true, but 
it didn't seem change anything.

When I'm testing out the bug, do you want me to try it out on the last ESR 
release of Fx24 which I use on my current browser with version 001? Or do you 
want me to use the latest version of firefox with version 005? And should I set 
hidden_tabs to true or false?

Original comment by swmaxi...@gmail.com on 7 Jan 2015 at 7:13

@GoogleCodeExporter
Copy link
Author

browser.sessionstore.restore_hidden_tabs is only to prevent loading tabs from 
inactive groups if the browser starts. It saves startup time, memory and 
traffic volume. The default setting is false. If you want to load all tabs at 
start then, you can set it to true. But it will not solve your problem.

We need only feedback for latest firefox with TGM 005.

You can use a portable fx version for test. Copy TMP+TGM addons to extension 
dir, copy the TGM folder and sessionstore.js in profile dir to the test 
profile. So you have all isolated from your standard installation and its easy 
to remove the test stuff later.



Original comment by micha.go...@arcor.de on 7 Jan 2015 at 9:09

@GoogleCodeExporter
Copy link
Author

>i see no good reasons to use an old Firefox version.

I'm not the OP, but the main reason I use an old Firefox is specifically 
because of this addon.  Up until recently, these new beta versions did not work 
reliably.  I haven't extensively tested this latest beta, but judging from the 
activity on the bug tracker there are still significant problems.  TGM is vital 
to my browsing style, so until this rewrite is working very, very smoothly, I 
stick with a very old version of Firefox specifically so that the old, original 
TGM will work.

Original comment by brenb...@gmail.com on 12 Jan 2015 at 6:55

@GoogleCodeExporter
Copy link
Author

Just to add onto this, I also use Palemoon specifically for this addon as I 
find it doesn't use as much resource compared to firefox. Before when I had 
this + Firefox the memory usage was over 2gigs, and yes that's with tons of 
tabs/groups. However with Palemoon it was reduced significantly by over a gig. 
I'm sure there's more people willing to test out Palemoon for this addon. I'm 
willing to do it.

Original comment by invade...@gmail.com on 28 Jan 2015 at 8:32

@GoogleCodeExporter
Copy link
Author

Hi brenbarn, unnafortunately our time is very limited and I wish we could do 
more releases in less time. At this moment we can only fix critical bugs, and 
usually they are quickly fixed.
If you want to try and experience the lastest TGM beta 005 and the lastest 
Firefox version, and share your impressions and bugs, in case you find 
anything, it will be really nice to fix them.
I usually handle 500+ tabs and still havent found any critical bug or even an 
issue with anything with the lastest versions, but I know there are still some 
of them hard to spot.
Thanks.

Original comment by miguelro...@gmail.com on 28 Jan 2015 at 9:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant