Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry errors during response parsing #1664

Merged

Conversation

technomunk
Copy link
Contributor

Issue

Amazon SNS seems to send 408 responses without any body, which trips up botocore.parser.QueryParser.

Solution

Retry any parse errors that contain "further retries may succeed" in their message.

Notes

Ideally the query parser should be updated to properly handle empty response bodies, but as I'm unfamiliar with that codebase I decided to make a fix in tomodachi instead 馃槆

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #1664 (7887f33) into master (131b522) will decrease coverage by 8.73%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1664      +/-   ##
==========================================
- Coverage   69.25%   60.51%   -8.74%     
==========================================
  Files          32       32              
  Lines        4153     4156       +3     
==========================================
- Hits         2876     2515     -361     
- Misses       1277     1641     +364     
Impacted Files Coverage 螖
tomodachi/transport/aws_sns_sqs.py 27.58% <0.00%> (-37.53%) 猬囷笍
tomodachi/discovery/aws_sns_registration.py 50.00% <0.00%> (-31.82%) 猬囷笍
tomodachi/helpers/middleware.py 88.46% <0.00%> (-3.85%) 猬囷笍
tomodachi/helpers/aiobotocore_connector.py 66.15% <0.00%> (-1.03%) 猬囷笍
tomodachi/transport/http.py 67.00% <0.00%> (+0.12%) 猬嗭笍
tomodachi/importer.py 68.51% <0.00%> (+0.92%) 猬嗭笍

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants