forked from apache/incubator-kie-docs
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for BXMSDOC-2811: Document new kie-server persistence feature #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmanwani-rh
reviewed
May 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaldesai I've added a few suggestions below. Please let me know if you've any questions.
doc-content/enterprise-only/admin-and-config/proc-configuring-kie-server-persistence.adoc
Outdated
Show resolved
Hide resolved
doc-content/enterprise-only/admin-and-config/proc-configuring-kie-server-persistence.adoc
Show resolved
Hide resolved
doc-content/enterprise-only/admin-and-config/proc-configuring-kie-server-persistence.adoc
Outdated
Show resolved
Hide resolved
doc-content/enterprise-only/admin-and-config/proc-configuring-kie-server-persistence.adoc
Outdated
Show resolved
Hide resolved
doc-content/enterprise-only/admin-and-config/proc-configuring-kie-server-persistence.adoc
Show resolved
Hide resolved
doc-content/enterprise-only/admin-and-config/proc-configuring-kie-server-persistence.adoc
Show resolved
Hide resolved
doc-content/enterprise-only/admin-and-config/proc-configuring-kie-server-persistence.adoc
Outdated
Show resolved
Hide resolved
doc-content/enterprise-only/admin-and-config/proc-configuring-kie-server-persistence.adoc
Outdated
Show resolved
Hide resolved
doc-content/enterprise-only/admin-and-config/proc-configuring-kie-server-persistence.adoc
Show resolved
Hide resolved
MarianMacik
reviewed
May 31, 2021
doc-content/enterprise-only/admin-and-config/proc-configuring-kie-server-persistence.adoc
Outdated
Show resolved
Hide resolved
doc-content/enterprise-only/admin-and-config/proc-configuring-kie-server-persistence.adoc
Outdated
Show resolved
Hide resolved
doc-content/enterprise-only/admin-and-config/proc-configuring-kie-server-persistence.adoc
Outdated
Show resolved
Hide resolved
Please remove me from this email chain. I believe I was added as a typo.
…On Mon, May 31, 2021, 11:56 AM Marián Macik ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
doc-content/enterprise-only/admin-and-config/proc-configuring-kie-server-persistence.adoc
<#121 (comment)>:
> @@ -0,0 +1,64 @@
+[id='proc-configuring-kie-server-persistence_{context}']
+
+= Configuring {KIE_SERVER} Persistence
+
+You can configure the {KIE_SERVER} persistence by passing hibernate or JPA parameters as system properties.
+
+To pass the hibernate or JPA parameters, use the following prefixes in your system properties:
I would rephrase this a bit, these prefixes are not prepended by a user,
rather it means that properties with these prefixes are recognized by a KIE
Server. So users can use every JPA or Hibernate parameters with these
prefixes. Also see the original JIRA which says so: kie-server will take
properties with following prefix into consideration:.
------------------------------
In
doc-content/enterprise-only/admin-and-config/proc-configuring-kie-server-persistence.adoc
<#121 (comment)>:
> +.Example of configuring {KIE_SERVER} persistence using hibernate parameters:
++
+[source]
+----
+$EAP_HOME/bin/standalone.sh -Dhibernate.hbm2ddl.auto=create-drop
+----
++
+.Example of configuring {KIE_SERVER} persistence using JPA parameters:
++
+[source]
+----
+$EAP_HOME/bin/standalone.sh -Djavax.persistence.jdbc.url=jdbc:mysql://mysql.db.server:3306/my_database?useSSL=false&serverTimezone=UTC
+----
+
+--
+. Start the {KIE_SERVER}.
Those 2 commands will already start the KIE Server with the specified
system properties.
------------------------------
In
doc-content/enterprise-only/admin-and-config/proc-configuring-kie-server-persistence.adoc
<#121 (comment)>:
> +.Example of configuring {KIE_SERVER} persistence using JPA parameters
++
+[source,xml,subs="attributes+"]
+----
+<system-properties>
+ ...
+ <property name="javax.persistence.jdbc.url" value="jdbc:mysql://mysql.db.server:3306/my_database?useSSL=false&serverTimezone=UTC"/>
+ ...
+<system-properties>
+----
+
+If you want to configure {KIE_SERVER} persistence using command line, complete the following tasks:
+
+... Pass the parameters directly from the command line using `-Dkey=value` as follows:
++
+.Example of configuring {KIE_SERVER} persistence using hibernate parameters:
hibernate should by with a capital letter, i.e. Hibernate. It is a name of
a community project. See https://hibernate.org/.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#121 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMRNLRVN2FLUQ4NEAUFKGLTQOWTHANCNFSM45SDS7TA>
.
|
MarianMacik
approved these changes
Jun 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks!
Please remove me from your mailing list
…On Tue, Jun 1, 2021, 7:29 AM Marián Macik ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good now, thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#121 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMRNLVJCNZ3B3RDMEB4WYTTQTAB5ANCNFSM45SDS7TA>
.
|
kaldesai
changed the title
WIP PR for BXMSDOC-2811: Document new kie-server persistence feature
PR for BXMSDOC-2811: Document new kie-server persistence feature
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.redhat.com/browse/BXMSDOC-2811
Doc preview: RHPAM-I. Managing and monitoring KIE Server
Doc impact: Please check 18.1. Configuring KIE Server Persistence