Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small logger improvement: non-static helper functions #2480

Open
Worldexe opened this issue Jun 7, 2018 · 2 comments
Open

Small logger improvement: non-static helper functions #2480

Worldexe opened this issue Jun 7, 2018 · 2 comments
Assignees
Labels
stale Stale bot on the loose

Comments

@Worldexe
Copy link

Worldexe commented Jun 7, 2018

I suggest making static std::string KaldiGetStackTrace() and const char *GetProgramName() in base/kaldi-error.cc non-static (and add prototypes to header), so they can be used in custom log handlers just like they are used in default handler.

@kkm000 kkm000 self-assigned this Apr 8, 2019
@kkm000
Copy link
Contributor

kkm000 commented Apr 8, 2019

The stack trace makes sense, but why GetProgramName? You set it, you get it back. I need to understand your motivation.

@stale
Copy link

stale bot commented Jun 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale bot on the loose label Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale bot on the loose
Projects
None yet
Development

No branches or pull requests

2 participants