This repository has been archived by the owner on Apr 2, 2019. It is now read-only.
Support microformats2 and internationalization #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've added microformats2 support to your plugin for semantic markup, as well as translations support using some of the tools provided by Grav/Antimatter.
I've updated the README and CHANGELOG consequently.
The hours is the only element not translated yet. I guess if we want to go further, using something like this is necessary (interesting for datetools).
If you have any questions/requests regarding this pull-request, don't hesitate!
You can see the code in action here.
Thanks for your amazing plugin!
PS: I've taken the liberty of updating version number to 1.0.10 everywhere, as it's the version that's being displayed in GPM. Otherwise, one is always prompted for updates even running the latest version. Also, you should probably bump it again if you accept to merge this PR :)